andr3/zls
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update config to highlight danger of the comptime interpreter (#1162)

Browse Source
This commit is contained in:
Sora 2023-04-30 19:21:43 +02:00 committed by GitHub
parent b4bcbeea55
commit 94882d2e64
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -75,7 +75,7 @@ The following options are currently available.
| `operator_completions` | `bool` | `true` | Enables `*` and `?` operators in completion lists | | `operator_completions` | `bool` | `true` | Enables `*` and `?` operators in completion lists |
| `warn_style` | `bool` | `false` | Enables warnings for style guideline mismatches | | `warn_style` | `bool` | `false` | Enables warnings for style guideline mismatches |
| `highlight_global_var_declarations` | `bool` | `false` | Whether to highlight global var declarations | | `highlight_global_var_declarations` | `bool` | `false` | Whether to highlight global var declarations |
| `use_comptime_interpreter` | `bool` | `false` | Whether to use the comptime interpreter | | `dangerous_comptime_experiments_do_not_enable` | `bool` | `false` | Whether to use the comptime interpreter |
| `include_at_in_builtins` | `bool` | `false` | Whether the @ sign should be part of the completion of builtins | | `include_at_in_builtins` | `bool` | `false` | Whether the @ sign should be part of the completion of builtins |
| `skip_std_references` | `bool` | `false` | When true, skips searching for references in std. Improves lookup speed for functions in user's code. Renaming and go-to-definition will continue to work as is | | `skip_std_references` | `bool` | `false` | When true, skips searching for references in std. Improves lookup speed for functions in user's code. Renaming and go-to-definition will continue to work as is |
| `max_detail_length` | `usize` | `1048576` | The detail field of completions is truncated to be no longer than this (in bytes) | | `max_detail_length` | `usize` | `1048576` | The detail field of completions is truncated to be no longer than this (in bytes) |

2
schema.json
View File

@ -74,7 +74,7 @@
"type": "boolean", "type": "boolean",
"default": "false" "default": "false"
}, },
"use_comptime_interpreter": { "dangerous_comptime_experiments_do_not_enable": {
"description": "Whether to use the comptime interpreter", "description": "Whether to use the comptime interpreter",
"type": "boolean", "type": "boolean",
"default": "false" "default": "false"

2
src/Config.zig
View File

@ -50,7 +50,7 @@ warn_style: bool = false,
highlight_global_var_declarations: bool = false, highlight_global_var_declarations: bool = false,
/// Whether to use the comptime interpreter /// Whether to use the comptime interpreter
use_comptime_interpreter: bool = false, dangerous_comptime_experiments_do_not_enable: bool = false,
/// Whether the @ sign should be part of the completion of builtins /// Whether the @ sign should be part of the completion of builtins
include_at_in_builtins: bool = false, include_at_in_builtins: bool = false,

4
src/analysis.zig
View File

@ -653,7 +653,7 @@ pub fn isTypeIdent(text: []const u8) bool {
.{"type"}, .{"anyerror"}, .{"type"}, .{"anyerror"},
.{"comptime_int"}, .{"comptime_float"}, .{"comptime_int"}, .{"comptime_float"},
.{"anyframe"}, .{"anytype"}, .{"anyframe"}, .{"anytype"},
.{"c_char"} .{"c_char"},
}); });
if (PrimitiveTypes.has(text)) return true; if (PrimitiveTypes.has(text)) return true;
@ -810,7 +810,7 @@ fn resolveTypeOfNodeUncached(analyser: *Analyser, node_handle: NodeWithHandle) e
const body = decl.handle.tree.nodes.items(.data)[decl_node].rhs; const body = decl.handle.tree.nodes.items(.data)[decl_node].rhs;
if (try analyser.resolveReturnType(fn_decl, decl.handle, if (has_body) body else null)) |ret| { if (try analyser.resolveReturnType(fn_decl, decl.handle, if (has_body) body else null)) |ret| {
return ret; return ret;
} else if (analyser.store.config.use_comptime_interpreter) { } else if (analyser.store.config.dangerous_comptime_experiments_do_not_enable) {
// TODO: Better case-by-case; we just use the ComptimeInterpreter when all else fails, // TODO: Better case-by-case; we just use the ComptimeInterpreter when all else fails,
// probably better to use it more liberally // probably better to use it more liberally
// TODO: Handle non-isolate args; e.g. `const T = u8; TypeFunc(T);` // TODO: Handle non-isolate args; e.g. `const T = u8; TypeFunc(T);`

2
src/config_gen/config.json
View File

@ -84,7 +84,7 @@
"default": "false" "default": "false"
}, },
{ {
"name": "use_comptime_interpreter", "name": "dangerous_comptime_experiments_do_not_enable",
"description": "Whether to use the comptime interpreter", "description": "Whether to use the comptime interpreter",
"type": "bool", "type": "bool",
"default": "false" "default": "false"