andr3/zls
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use plain text if the client tells zls it's preferred

Browse Source 
LSP clients send a list of supported formats for definition and
completion; the specification says "the order describes the preferred
format of the client."[1]

My client sends:

	'hover': {'contentFormat': ['plaintext', 'markdown']},

So it should prefer plaintext, using markdown if that's not supported by
the server. zls behaved slightly different: it would use Markdown if it
appears at all in the list of supported formats.

This fixes it so that it will use plain text if that appears before
'markdown' in the list.

[1]: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_hover
This commit is contained in:
Martin Tournoij 2023-04-13 07:33:43 +02:00
parent d2287816a7
commit 622efdcd6a
No known key found for this signature in database
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Server.zig
View File

@ -399,6 +399,9 @@ fn initializeHandler(server: *Server, request: types.InitializeParams) Error!typ
if (textDocument.hover) |hover| { if (textDocument.hover) |hover| {
if (hover.contentFormat) |content_format| { if (hover.contentFormat) |content_format| {
for (content_format) |format| { for (content_format) |format| {
if (format == .plaintext) {
break;
}
if (format == .markdown) { if (format == .markdown) {
server.client_capabilities.hover_supports_md = true; server.client_capabilities.hover_supports_md = true;
break; break;
@ -412,6 +415,9 @@ fn initializeHandler(server: *Server, request: types.InitializeParams) Error!typ
server.client_capabilities.supports_snippets = completionItem.snippetSupport orelse false; server.client_capabilities.supports_snippets = completionItem.snippetSupport orelse false;
if (completionItem.documentationFormat) |documentation_format| { if (completionItem.documentationFormat) |documentation_format| {
for (documentation_format) |format| { for (documentation_format) |format| {
if (format == .plaintext) {
break;
}
if (format == .markdown) { if (format == .markdown) {
server.client_capabilities.completion_doc_supports_md = true; server.client_capabilities.completion_doc_supports_md = true;
break; break;