andr3/zls
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid accessing inactive union fields in completeDot (#1115)

Browse Source 
As reported on Discord by CodotakuYT:
```zig
fn populate(T: type, index: i32) T {
    _ = index;
    @typeInfo(T).struct.
}
```
```
thread 17384 panic: access of union field 'ast_node' while field 'param_payload' is active
C:\Users\taoua\zls\src\features\completions.zig:875:61: 0x7ff68070caac in completeDot (zls.exe.obj)
                const node_data = nodes_data[local_decl.decl.ast_node];
```
This commit is contained in:
nullptrdevs 2023-04-05 07:28:21 -07:00 committed by GitHub
parent 7814a05921
commit 55b1aeb6f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/features/completions.zig
View File

@ -872,6 +872,10 @@ fn completeDot(server: *Server, handle: *const DocumentStore.Handle, source_inde
if (maybe_decl) |local_decl| { if (maybe_decl) |local_decl| {
const nodes_tags = handle.tree.nodes.items(.tag); const nodes_tags = handle.tree.nodes.items(.tag);
const nodes_data = handle.tree.nodes.items(.data); const nodes_data = handle.tree.nodes.items(.data);
switch (local_decl.decl.*) {
.ast_node => {},
else => break :struct_init,
}
const node_data = nodes_data[local_decl.decl.ast_node]; const node_data = nodes_data[local_decl.decl.ast_node];
if (node_data.rhs != 0) { if (node_data.rhs != 0) {
switch (nodes_tags[node_data.rhs]) { switch (nodes_tags[node_data.rhs]) {