Commit Graph

870 Commits

Author SHA1 Message Date
Cas Cremers
d9e17005ae Fix duplicate trampoline counting bug in script. 2018-10-21 17:29:55 +02:00
Cas Cremers
54b3654b07 Updated regression tests. 2018-10-21 17:09:29 +02:00
Cas Cremers
1c3e32a2da Refactoring. 2018-10-19 21:28:22 -04:00
Cas Cremers
178c20a61c Refactoring code. 2018-10-19 20:27:35 -04:00
Cas Cremers
024a76a32b Minor refactoring. 2018-10-19 20:17:50 -04:00
Cas Cremers
45b2d97883 Another trampoline gone. 2018-10-19 16:17:06 -04:00
Cas Cremers
24c6e47f07 Removed dead code that nevertheless produced a trampoline warning. 2018-10-19 16:08:47 -04:00
Cas Cremers
15c64c8a55 Down to 20. 2018-10-19 16:06:08 -04:00
Cas Cremers
38d57ed91d Nearly at 20 trampolines left. 2018-10-19 16:01:44 -04:00
Cas Cremers
9da05f738c Another trampoline gone. 2018-10-19 15:55:39 -04:00
Cas Cremers
e831a9d51b Another simple trampoline removed. 2018-10-19 15:51:47 -04:00
Cas Cremers
fe2bc26e71 Removed one more. 2018-10-19 15:46:48 -04:00
Cas Cremers
6ee81d304d Another double trampoline removed. 2018-10-19 15:43:08 -04:00
Cas Cremers
38bb02aa61 Removed another simple trampoline. 2018-10-19 15:33:41 -04:00
Cas Cremers
d4c188659c Removed another trampoline. 2018-10-19 15:28:51 -04:00
Cas Cremers
26bf502428 Removed another trampoline. 2018-10-19 15:18:17 -04:00
Cas Cremers
ad06600bd8 Removed a further simple trampoline. 2018-10-19 15:10:28 -04:00
Cas Cremers
128189bb54 Added counter script. 2018-10-19 14:35:56 -04:00
Cas Cremers
ac7e0a144b Fixed another nested functions. 2018-10-15 17:31:53 -04:00
Cas Cremers
0d9c23c33b Reindent code for consistency. 2018-10-15 09:40:07 -04:00
Cas Cremers
369ae1e3f8 Refactoring another bit of code to avoid trampoline. 2018-10-14 22:11:25 +02:00
Cas Cremers
b56c66db0b Added some safety checks and a missing deVar to the code that localises terms. 2018-10-14 22:00:16 +02:00
Cas Cremers
69c0486376 Another removal of a nested function.
Note this one is relatively complex and error prone.
2018-10-14 21:46:55 +02:00
Cas Cremers
ec8ea5f95c Copied another iterator to remove a trampoline. 2018-10-14 20:51:19 +02:00
Cas Cremers
2ad030f919 Removed another nested function by duplicating iterator code. 2018-10-14 20:42:54 +02:00
Cas Cremers
7956eb5953 Removed a simple nested function. 2018-10-14 17:43:13 +02:00
Cas Cremers
08adc5b518 Removed a further nested function call. 2018-10-14 17:39:29 +02:00
Cas Cremers
2b4af1c290 Removed nested function in goal_add. 2018-10-14 17:29:15 +02:00
Cas Cremers
61beae203b Got rid of one nested function. 2018-10-14 17:19:05 +02:00
Cas Cremers
792eaab09c Enable warning to help locate the problem areas to fix. 2018-10-14 17:04:42 +02:00
Cas Cremers
457c68580f Added explicit flag for using gnu89 C standard. 2015-11-27 21:07:30 +00:00
Cas Cremers
6374683d17 Visualisation improvement: role variables get priority in assigning concrete values.
Previously, if a local (non-role) variable would have (implicit) agent type,
it would be assigned a concrete term before the roles. This would lead to
non-optimal choices, since we care more about the role instantiations than about other variables.

However, when making traces concrete, we use the run's 'locals' list. Because of
the way this is constructed (in reverse), non-role variables precede the role variables.
We therefore choose to traverse the list in reverse.
2014-07-06 21:31:20 +01:00
Cas Cremers
b0e5128e23 Attack output improvement: better choice of agent names.
When an attack pattern is displayed, Scyther instantiates open variables with concrete names.
This is often more intuitive for humans.

In the case of instantiating role names, we often ended up assigning Alice to the B role and
Bob to the A role. This patch provides a more clever heuristic to find agent names
that start with the same letter as the role (variable) name. In case this fails, we
still try to map Alice to roles starting with 'I' and Bob to 'R', and otherwise we just pick something.

Also added "Simon" and "Pete" to cover some common role names.

Conflicts:
	src/arachne.c
2014-06-30 17:06:23 +01:00
Cas Cremers
e966bc88dd BUGFIX: --one-role-per-agent switch had a bug that made it cut too many patterns. 2014-06-20 17:30:13 +01:00
Cas Cremers
f1f2f28f61 Rewriting option parser wrapper to ensure memory is not lost.
The option parser wrapper allocated memory in an incorrect way, which
could lead to problems especially with --xml-output, since it would
access the memory at a later point in the execution. This could then
propagate to GUI problems, since the GUI uses the --xml-output switch.
Rewrote the code to be more readable and less incorrect.
2014-06-10 14:37:40 +01:00
Cas Cremers
9cc323004c Cleanup: Refactoring XML output code to facilitate introduction of protocol xml output. 2014-04-15 22:12:43 +01:00
Cas Cremers
dc4432a18f Cleanup: Removing unused variables. 2014-04-15 22:12:12 +01:00
Cas Cremers
4fa48239a5 Cleanup: added missing header files. 2014-03-18 13:53:51 +00:00
Cas Cremers
7dcbec07a0 Cleanup: removing unused variables. 2014-03-18 13:53:33 +00:00
Cas Cremers
3df93c42e4 Bugfix: compilation was not working on recent 64-bit Ubuntu versions.
This patch addresses two 64-bit platform compilation issues:
- Force 32-bit mode for gcc using '-m32'
- Recent library modifications broke the 32-bit compilation on 64-bit machines: updated
  'compile.txt' to include the need for the 'gcc-multilib' package.
2014-02-18 10:53:24 +00:00
Cas Cremers
a20f3760e7 Updating URLs. 2013-12-23 13:11:48 +00:00
Cas Cremers
1a9d088aa8 Updated installation and compilation notes. 2013-12-11 16:48:20 +00:00
Cas Cremers
d06247fcfe Updating time stamps for next release. 2013-10-05 23:56:12 +01:00
Cas Cremers
4e78a1d3fa Removing obsolete file. 2013-10-05 23:49:13 +01:00
Cas Cremers
6134b46557 Backend DOT graph generation: Removing redundant ';' which seems to confuse more recent versions of Graphviz (>2.26) 2013-06-19 23:03:36 +02:00
Cas Cremers
45d5cb0a3a Cleanup: Cleanup of some spacing, conform coding conventions.
This is simply the result from running reindent.sh again.
2013-06-19 23:03:26 +02:00
Cas Cremers
c6280d745e Backend DOT graph generation: Removing debugging reporting of 'cost' in attack graphs.
This was confusing to casual users.
2013-06-19 23:02:58 +02:00
Cas Cremers
fe25a53232 Regression-fix: Reintroduced option for alternative PKI.
Changes:

1. Reverted restricted use of 'hashfunction': 'function' can now be used as an alternative (but they are identical).
2. Functions can be specified to be secret, as we had before.

Together with the newer 'inversekeyfunctions' declaration, this allows for the clean definition of alternative key infrastructures.

Example usage:

  secret function sk2;
  function pk2;
  inversekeyfunctions (sk2,pk2);

Conflicts:
	src/compiler.c
2013-05-24 11:27:14 +02:00
Cas Cremers
5c2eded8f9 Weakagree and Alive claims now also allow for a role parameter + BUGFIX.
Previously, weak agreement and aliveness claims would enforce a requirement for all agents in the range
of the rho of the claim run.

For some three-party protocols this was stronger than needed. We now allow an
optional role name parameter for these claims; if such a parameter is used, the claim
is only evaluated for the agents performing that role.

En passant fixed a potential bug: aliveness and weak agreement require a run for each
agent, but previously we didn't check if these were helper protocols. Clearly they
should not be.
2013-05-24 11:27:14 +02:00
Cas Cremers
7658644295 Rati Gelashvili reported a rare but annoying bug in the hash function handling.
The fix requires a significant reworking of the function handling. This
is a first attempt.

Conflicts:
	src/knowledge.c
	src/knowledge.h

Regression test suggests that the Hashfunction fix works.
2013-04-26 14:47:27 +02:00