From a3828a028fcccbff7341d375beab6ea4905d9f14 Mon Sep 17 00:00:00 2001
From: ccremers <ccremers@4f7d145f-a0d4-0310-ae10-d96cc04433c1>
Date: Fri, 13 Aug 2004 14:35:22 +0000
Subject: [PATCH] - Fixed the very annoying bug! The problem was in
 roleInstance for   Arachne. When a subst was carried out by an
 Rolename->compoundTerm   substitution, the compound term was not duplicated,
 and this caused   problems at roledef destruction.

---
 src/arachne.c |  3 ++-
 src/mgu.c     | 73 +++++++++++++++++++++++++++------------------------
 src/system.c  | 10 +++----
 3 files changed, 45 insertions(+), 41 deletions(-)

diff --git a/src/arachne.c b/src/arachne.c
index 824080d..f4ff122 100644
--- a/src/arachne.c
+++ b/src/arachne.c
@@ -278,10 +278,11 @@ bind_new_run (const Goal goal, const Protocol p, const Role r,
   e_term2 = rd->message;
 #endif
 
-  iterate ();
+  flag = iterate ();
 
   goal.rd->bind_run = old_run;
   goal.rd->bind_index = old_index;
+
   roleInstanceDestroy (sys);
   return flag;
 }
diff --git a/src/mgu.c b/src/mgu.c
index 8afcc63..e46e900 100644
--- a/src/mgu.c
+++ b/src/mgu.c
@@ -208,46 +208,49 @@ termMguSubTerm (Term t1, Term t2, int (*iterator) (),
 
   flag = 1;
   t2 = deVar (t2);
-  if (t2 != NULL && !isTermLeaf (t2))
+  if (t2 != NULL)
     {
-      if (isTermTuple (t2))
+      if (!isTermLeaf (t2))
 	{
-	  // 'simple' tuple
-	  flag =
-	    flag && termMguSubTerm (t1, t2->left.op1, iterator, inverses,
-				   keylist);
-	  flag =
-	    flag && termMguSubTerm (t1, t2->right.op2, iterator, inverses,
-				   keylist);
+	  if (isTermTuple (t2))
+	    {
+	      // 'simple' tuple
+	      flag =
+		flag && termMguSubTerm (t1, t2->left.op1, iterator, inverses,
+					keylist);
+	      flag =
+		flag && termMguSubTerm (t1, t2->right.op2, iterator, inverses,
+					keylist);
+	    }
+	  else
+	    {
+	      // Must be encryption
+	      // So, we need the key, and try to get the rest
+	      Termlist keylist_new;
+	      Term newkey;
+
+	      keylist_new = termlistShallow (keylist);
+	      newkey = inverseKey (inverses, t2->right.key);
+	      keylist_new = termlistAdd (keylist_new, newkey);
+
+	      // Recurse
+	      flag =
+		flag && termMguSubTerm (t1, t2->left.op, iterator, inverses,
+					keylist_new);
+
+	      termlistDelete (keylist_new);
+	      termDelete (newkey);
+	    }
 	}
-      else
+      // simple clause or combined
+      tl = termMguTerm (t1, t2);
+      if (tl != MGUFAIL)
 	{
-	  // Must be encryption
-	  // So, we need the key, and try to get the rest
-	  Termlist keylist_new;
-	  Term newkey;
-
-	  keylist_new = termlistShallow (keylist);
-	  newkey = inverseKey (inverses, t2->right.key);
-	  keylist_new = termlistAdd (keylist_new, newkey);
-
-	  // Recurse
-	  flag =
-	    flag && termMguSubTerm (t1, t2->left.op, iterator, inverses,
-				    keylist_new);
-
-	  termlistDelete (keylist_new);
-	  termDelete (newkey);
+	  // Iterate
+	  flag = flag && iterator (tl, keylist);
+	  // Reset variables
+	  termlistSubstReset (tl);
 	}
     }
-  // simple clause or combined
-  tl = termMguTerm (t1, t2);
-  if (tl != MGUFAIL)
-    {
-      // Iterate
-      flag = flag && iterator (tl, keylist);
-      // Reset variables
-      termlistSubstReset (tl);
-    }
   return flag;
 }
diff --git a/src/system.c b/src/system.c
index 445fbe8..9708ba9 100644
--- a/src/system.c
+++ b/src/system.c
@@ -591,11 +591,12 @@ roleInstance (const System sys, const Protocol protocol, const Role role,
 	  Term newt, oldt;
 
 	  oldt = scanfrom->term;
-	  newt = deVar (oldt);
+	  newt = oldt;
 	  if (realTermVariable (newt))
 	    {
 	      // Make new var for this run
 	      newt = makeTermType (VARIABLE, newt->left.symb, rid);
+	      newt->subst = oldt->subst;
 	      artefacts = termlistAdd (artefacts, newt);
 	    }
 	  // Add to agent list, possibly
@@ -689,13 +690,12 @@ roleInstance (const System sys, const Protocol protocol, const Role role,
 void
 roleInstanceDestroy (const System sys)
 {
-  int runid;
-
-  runid = sys->maxruns - 1;
-  if (runid >= 0)
+  if (sys->maxruns > 0)
     {
+      int runid;
       struct run myrun;
 
+      runid = sys->maxruns - 1;
       myrun = sys->runs[runid];
 
       // Destroy roledef